Great advice for approaching a PhD supervisor! My advice starts further back- starting with, consider your motivation for grad school, and how to identify a potential supervisor. @JacquelynGill has a great PhD guide: